Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Lo DE segmented packet string commas #1144

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Removed Lo DE segmented packet string commas #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e4ad3f
removed packet seg commas
sdhoyt Nov 12, 2024
aa39626
updated unit test
sdhoyt Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion imap_processing/lo/l0/lo_science.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def combine_segmented_packets(dataset: xr.Dataset) -> xr.Dataset:
# Mark the segment splits with comma to identify padding bits
# when parsing the binary
dataset["events"] = [
",".join(dataset["data"].values[start : end + 1])
"".join(dataset["data"].values[start : end + 1])
for start, end in zip(seg_starts, seg_ends)
]
# drop any group of segmented packets that aren't sequential
Expand Down
4 changes: 2 additions & 2 deletions imap_processing/tests/lo/test_lo_science.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ def test_combine_segmented_packets(segmented_pkts_fake_data):
dataset["events"].values,
np.array(
[
"0000000001,0000000010,0000000100,0000001000",
"0000000001000000001000000001000000001000",
"0000010000",
"0100000000,1000000000",
"01000000001000000000",
]
),
)
Expand Down
Loading