Add calculation of Hi L1B nominal_bin #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test coverage for nominal_bin calculation
subagonsouth
requested review from
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
laspsandoval
approved these changes
Nov 6, 2024
imap_processing/hi/l1b/hi_l1b.py
Outdated
| # nominal_bin is the index number of the 90 4-degree bins that each DE would | ||
| # be binned into in the histogram packet. The Hi histogram data is binned by | ||
| # spacecraft spin-phase, not instrument spin-phase, so the same is done here. | ||
| met_querry_times = j2000ns_to_j2000s(dataset.event_met.values) |
subagonsouth
merged commit a345050
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
New Dependencies
New Files
Deleted Files
Updated Files
compute_instrument_spin_phasetode_nominal_bin_and_spin_phaseCloses: #866