Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up main into separate files and added CPU timeline #15

Open
wants to merge 43 commits into
base: paper-2.2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
62bc7d5
Break up main into separate files
lauren45983 Nov 4, 2020
3320b21
Added image of graph
lauren45983 Nov 4, 2020
fb56690
Coded the trial conditions in the data so that we can compare data
lauren45983 Nov 6, 2020
3e64bc7
Moved over the inter trial analysis into their own file
lauren45983 Nov 13, 2020
16bbb30
Hotfix for missing check_qs
charmoniumQ Nov 17, 2020
150c828
added desktop sponza results
Hyjale Nov 17, 2020
4f47126
Hotfix for missing check_qs (part 2)
charmoniumQ Nov 17, 2020
cd31a71
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
Hyjale Nov 17, 2020
1ee3c6d
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
Hyjale Nov 17, 2020
e30373b
Updated README.md to be up to date with changes in results
lauren45983 Nov 18, 2020
f350a77
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
lauren45983 Nov 18, 2020
1918d91
Added documentation
charmoniumQ Nov 18, 2020
4728022
Remove ILLIXR
charmoniumQ Nov 18, 2020
88e376f
Update docs
charmoniumQ Nov 18, 2020
1158d7a
Update docs
charmoniumQ Nov 18, 2020
21c1cb1
Removed commented out code that is now in per/inter trial analysis
lauren45983 Nov 20, 2020
2e344c2
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
lauren45983 Nov 20, 2020
2ffe8c8
Added timers for duration of each function
lauren45983 Nov 20, 2020
f7751a2
Removed obsolete code
charmoniumQ Nov 20, 2020
03c3c7b
Merge branch 'improved-script' of github.com:ILLIXR/results into impr…
charmoniumQ Nov 20, 2020
566382d
Automated all graphs except power
JeffreyZh4ng Nov 21, 2020
d032989
Merge
JeffreyZh4ng Nov 21, 2020
d8bbe38
Added files that I forgot about
JeffreyZh4ng Nov 22, 2020
f813279
ISCA results v1
mhuzai Nov 22, 2020
a409855
Add missing results
mhuzai Nov 22, 2020
12e17dc
Power and MTP done
JeffreyZh4ng Nov 22, 2020
72ab5f5
Lotta new graphs
JeffreyZh4ng Nov 23, 2020
d38695b
Graph nits, pretty much finalized
JeffreyZh4ng Nov 23, 2020
d4fe726
Many more graphs and style changes
JeffreyZh4ng Nov 25, 2020
fc37b9f
Final push
JeffreyZh4ng Nov 25, 2020
9938463
Added some code comments
JeffreyZh4ng Nov 25, 2020
c4195ff
Added Named Tuple Documentation
lauren45983 Dec 2, 2020
5a493a7
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
lauren45983 Dec 2, 2020
8138c56
Merge branch 'improved-script' of github.com:ILLIXR/results into impr…
charmoniumQ Dec 2, 2020
32993a8
Moved plot graphs into inter trial analysis
lauren45983 Dec 4, 2020
e681806
Merge branch 'improved-script' of https://github.com/ILLIXR/results i…
lauren45983 Dec 4, 2020
cebf870
Ammend previous commit
lauren45983 Dec 4, 2020
7cdfc7d
Merged fps/frequency graphs into the inter_trial_analysis
charmoniumQ Dec 6, 2020
fe0eaea
Added cpu_timer3 data
charmoniumQ Dec 18, 2020
9c69790
Update README.md
charmoniumQ Dec 19, 2020
bc9f556
Update README.md
charmoniumQ Dec 19, 2020
a24f67c
Update README.md
charmoniumQ Dec 19, 2020
f2f8584
wip
charmoniumQ Apr 8, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "ILLIXR"]
path = ILLIXR
url = [email protected]:ILLIXR/ILLIXR.git
10 changes: 0 additions & 10 deletions Graphs/ExampleStackedBar.csv

This file was deleted.

Empty file removed Graphs/ExampleTimeSeries.csv
Empty file.
Binary file added Graphs/cpu-breakdown.pdf
Binary file not shown.
Binary file added Graphs/freq/desktop.pdf
Binary file not shown.
Binary file added Graphs/freq/jetsonhp.pdf
Binary file not shown.
Binary file added Graphs/freq/jetsonlp.pdf
Binary file not shown.
87 changes: 0 additions & 87 deletions Graphs/make_bar_chart.py

This file was deleted.

Binary file added Graphs/microarchitecture.pdf
Binary file not shown.
Binary file added Graphs/mtp-ar.pdf
Binary file not shown.
Binary file added Graphs/mtp-materials.pdf
Binary file not shown.
Binary file added Graphs/mtp-platformer.pdf
Binary file not shown.
Binary file added Graphs/mtp-sponza.pdf
Binary file not shown.
Binary file added Graphs/power-breakdown.pdf
Binary file not shown.
Binary file added Graphs/power-total.pdf
Binary file not shown.
Binary file added Graphs/time-desktop.pdf
Binary file not shown.
Binary file added Graphs/time-jhp.pdf
Binary file not shown.
Binary file added Graphs/time-jlp.pdf
Binary file not shown.
Binary file added Graphs/timeseries-platformer-desktop-1.pdf
Binary file not shown.
Binary file added Graphs/timeseries-platformer-desktop-2.pdf
Binary file not shown.
1 change: 0 additions & 1 deletion ILLIXR
Submodule ILLIXR deleted from 881f45
24 changes: 19 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
- The exact code I used is in [`ILLIXR`](./ILLIXR) (submodule)/.
- An exact copy of the metrics I recovered are available in [`metrics`](./metrics), so this analysis is reproducible.
- Read [`trial_conditions.yaml`](./trial_conditions.yaml) for trial conditions/environment.
- To run the analysis yourself, see [`./analysis/README.md`](./analysis/README.md).
- Read [`output/README.md`](./output/) for interesting things in the output.
# Adding Data
1. Follow our [Getting Started](https://illixr.github.io/ILLIXR/getting_started/) guide to run ILLIXR.
* If you want meaningful results, set `profile: opt` in the `config/$YOUR_CONFIG.yaml` where `$YOUR_CONFIG.yaml` is the config you want to run for your experiment.
2. Running `cd ILLIXR ; ./runner.sh config/$YOUR_CONFIG.yaml` should create a directory called `ILLIXR/metrics/`. Move this directory to `results/metrics/$NAME` where `results` is this repo and `$NAME` is an arbitrary unused directory name.
3. Add metadata to `metrics/$NAME/trial_conditions.yaml`. See `analysis/util.py:TrialConditions` for the schema of this YAML. You can add extra fields if you have extra experimental conditions to track; I will always encourage people to embed machine-readable labels their data :)

# Running the Script
1. If this is your first time invoking thi script, install the dependencies by `cd results/analysis ; poetry install`.
2. Run `cd results/analysis ; poetry run python3 main.py`. This will run all of the analyses on all of the data.
3. Examine the results in `output/`. Note that `output/$NAME` corresponding to `metrics/$NAME`. `output/account_summaries.md` is a very good place to start.

# Adding an Analysis or Plot
- Per-trial and inter-trial analyses can be found in the `analysis/per-trial-analysis.py` and `analysis/inter-trial-analysis.py` files, respectively.
- Per-trial analyses takes a single `PerTrialData`, while inter-trial analyses take a list of `PerTrialData`. See `analysis/util.py:PerTrialData` for what each attribute means.
- The `analysis` functions in each file run all inter-trial or per-trial analysis within.
- We've found it helpful to comment out the slow ones.
- Running the analyses is a slow way of revealing errors; To speed up development, you can quickly type check your analyses using Mypy,
- Run `cd results/analysis ; poetry install --dev` and `poetry run mypy --strict --ignore-missing-imports main.py`.
- Use `:` and `->` to signify the parameter-types and return-type of new functions (e.g. `def foo(x: int, y: float) -> str`).
Loading