Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gha): add golangci-lint to code #45

Merged
merged 6 commits into from
Oct 25, 2023
Merged

feat(gha): add golangci-lint to code #45

merged 6 commits into from
Oct 25, 2023

Conversation

georgettica
Copy link
Contributor

related to #44

@georgettica
Copy link
Contributor Author

I think this PR will not be easily tested before we merge the PR and test on a new one, this means to merge and that I will fix in an additional PR

@ravin-d-27
Copy link
Collaborator

ravin-d-27 commented Oct 15, 2023 •
edited
Loading

Hi @georgettica , could you please let us know when can you make the additional PR?

@georgettica
Copy link
Contributor Author

I just want to verify, there are a few ways to do this:
Create an empty GitHub action and push it, then rebase it on top.

Merge this and create a dummy pr

@georgettica
Copy link
Contributor Author

2 things come to mind why this is not working:

  1. the repo doesn't have github actions enabled
  2. I made a mistake and forgot to add a segment to thr already pushed github action

@georgettica
Copy link
Contributor Author

nope, the issue is me :( wrong path

@georgettica
Copy link
Contributor Author

CI runs!

@georgettica
Copy link
Contributor Author

PR passes, I added README to allow for others to change components and fix their tests before this is merged

@ravin-d-27 ravin-d-27 merged commit ed44691 into IEEE-VIT:main Oct 25, 2023
1 check passed
@ravin-d-27
Copy link
Collaborator

Great job @georgettica !

ravin-d-27
ravin-d-27 reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@ravin-d-27 ravin-d-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravin-d-27 ravin-d-27 ravin-d-27 left review comments

@RohithParahmesh RohithParahmesh Awaiting requested review from RohithParahmesh RohithParahmesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgettica @ravin-d-27