Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /triplets route and tests #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agent515
Copy link

@agent515 agent515 commented Oct 6, 2020

Issue #76
Added /triplets endpoint and also tests for the same.

Please review this PR and if you're satisfied put hacktoberfest-accepted label on it. : )

@agent515
Copy link
Author

agent515 commented Oct 9, 2020

Please review this PR @ZiyanK and if found okay, put a hacktoberfest-accepted label on it.
Thanks.

@ZiyanK
Copy link
Member

ZiyanK commented Oct 11, 2020

Route doesn't seem to be working. Kindly fix it.

@agent515
Copy link
Author

@ZiyanK
body = {
"sides": [3, 4, 5]
}
is the valid body.

I'm sorry because I didn't change it in the docstring of the endpoint. I'll push those changes now.
Can you check again with this request body?

@agent515
Copy link
Author

@ZiyanK
Refer test cases to test the endpoint..
I've tested API on Postman and npm run test passes all the testcases

@IEEE-VIT IEEE-VIT deleted a comment from agent515 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants