-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests and debug #11
Merged
tpoignonec
merged 13 commits into
add_cartesian_admittance_controller
from
integration_tests_and_debug
Oct 29, 2023
Merged
Integration tests and debug #11
tpoignonec
merged 13 commits into
add_cartesian_admittance_controller
from
integration_tests_and_debug
Oct 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tpoignonec
commented
Oct 29, 2023
- fix NaN errors (see bcb3e15)
- fix state interface issue (see fbbf9d3)
- general clean-up
- test with mock hardware
tpoignonec
merged commit Oct 29, 2023
5ca7ce0
into
add_cartesian_admittance_controller
1 check passed
tpoignonec
added a commit
that referenced
this pull request
Apr 25, 2024
* Add roadmap for beta version * Ininitial boilerplate: - copy ros2_controllers/admittance_controller - rename files and namespace - adapt for cartesian control (only partially) * start controller description in README.md * Update README.md : - "command" instead of "target" - use acceleration command * add empty admittance solver structure * implement vanilla rule * use a trajectory of reference compliant frames * move compliance trajectory data to dedicated class * fix AdmittanceState * plugify rules * fix plugin init/configure error * fix export plugin * make controller a normal controller (as opposed to a chainable one) * use frame trajectory msg * fix errors + split update_ref from update * move load admittance_rule to configure * add basic tests * major edits: introduce an "admittance_frame and move fill_traj to rule cpp * add set cart ref from eigen method * add "init_reference_frame_trajectory()" method * fix getters/setters in frame trajectory * reset ref at startup * make CartesianAdmittanceRule more verbose * fix tests * uncrustify * add custom kinematics_interface version (VCS) * run pre-commit * fix ref frame for admittance * update workflow * add some verbose * fix wrench in wrong frame * minor fixes * add disclaimer in README.md * update README.md * make CI less sad * Integration tests and debug (#11) * draft launch and config * fix ros2-control layer + launch * more realistic impedance params * store last commanded twist * fix init rule * add broadcasters for debug * update launch * fix state reading (RQ: pareil sur le repos ros!!!) * general clean-up * comment interaction (will use ft interface later) * update params and visu (foxglove) * make CI happy --------- Co-authored-by: iris@I2RM_PC2 <iris@I2RM_PC2> * fix gravity compensation * reduce stiffness * cleanup config * fix command_interface indexing and add verbose * make CI happier * fix VCS * fix kinematics_interface branch name * add CompliantFrameTrajectory::resize() func. * resize trajectory container if needed * make impedance profile matrices dense * fill target compliance from msg * add impedance to AdmittanceState * set velocities to zero in case of errors * log and publish controller state * add: stamp status msg * add filter velocity * extra linting * add joint commands to cartesian ctrl status * filter position as well as state * add cutoff freqs to parameters * linting * add cmd filter * add deps to "hardware_interface_testing" * fix test config * add test verbose * remove commented verbose * fix tests * clean-up files --------- Co-authored-by: iris@I2RM_PC2 <iris@I2RM_PC2> Co-authored-by: iris2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.