feat: improve error responses #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiri
force-pushed
the
s1004-error-augmentation
branch
from
0e3e155
to
42ffe89
Compare
eiri
force-pushed
the
s1004-error-augmentation
branch
from
5cc5641
to
2564298
Compare
ricellis
approved these changes
Oct 29, 2024
eiri
force-pushed
the
s1004-error-augmentation
branch
from
1e8f77a
to
1553097
Compare
eiri
force-pushed
the
s1004-error-augmentation
branch
from
1553097
to
63a4641
Compare
This PR adds a new RoundTripper to augment error messages and adds it to http client in middleware fashion at creation of BaseService or at SetHTTPClient call. The change covered by new test suite.
Co-authored-by: Rich Ellis <[email protected]> Signed-off-by: Eric Avdey <[email protected]>
eiri
force-pushed
the
s1004-error-augmentation
branch
from
326fdbd
to
65fb094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR adds a new RoundTripper to augment error messages and adds it to http client in middleware fashion at creation of BaseService or at SetHTTPClient call.
The change covered by new test suite.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information