AspOpenList: use recordLength to avoid offset issues from the new fields in v75 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Marshall <[email protected]>
JMConnect
force-pushed
the
AspOpenList-offset
branch
from
a585447
to
a6729d9
Compare
|
Another issue here is getBestGuessReceiverSize returns too small of a number for some of these now and it has to re-run with a larger receiver variable. I could adjust this to return updated record lengths based on the system version if that makes sense and wouldn't cause other issues. |
Seems safe and reasonable |
Signed-off-by: John Marshall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.5 (and maybe some patch levels of 7.4?) some of the QYASPOL formats have added fields. The recordLength value was not taken into account and for these systems the values read were incorrectly offset after the first record.