Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizing the naming of LYVE1 vs. LYVE-1. #141

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

zivy
Copy link
Member

@zivy zivy commented Apr 29, 2024

The naming was harmonized to LYVE-1.

resolves #119

The naming was harmonized to LYVE-1.

resolves IBEXImagingCommunity#119
@zivy zivy requested a review from radtkea April 29, 2024 13:52
Copy link
Contributor

@radtkea radtkea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I see that you deleted the "LYVE1_Unconjugated" and "LYVE1_eF570" supplementary materials. These are replaced with "LYVE-1_Unconjugated" and "LYVE-1_eF570"?

@zivy
Copy link
Member Author

zivy commented Apr 29, 2024

Yes. That is correct. Please make sure the data merge and file renaming are correct. It they are approve, if not point out the errors. Thanks.

Copy link
Contributor

@radtkea radtkea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Approve:)

@zivy zivy merged commit 09e0ebc into IBEXImagingCommunity:main Apr 29, 2024
3 checks passed
@zivy zivy deleted the harmonizeLYVE1Spelling branch April 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change LYVE1 to LYVE-1: Easy fix?
2 participants