Merge pull request #353 from IATI/develop

fix: address remaining mypy warnings
IATI · Sep 5, 2024 · 15b381b · 15b381b
2 parents 8d8f2fa + 91dcd7e
commit 15b381b
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 5 deletions.
diff --git a/requirements_dev.in b/requirements_dev.in
@@ -8,6 +8,7 @@ Flake8-pyproject
 black
 mypy
 types-requests
+types-urllib3
 types-psycopg2
 types-python-dateutil
 lxml-stubs
diff --git a/requirements_dev.txt b/requirements_dev.txt
@@ -120,6 +120,8 @@ types-python-dateutil==2.9.0.20240316
     # via -r requirements_dev.in
 types-requests==2.32.0.20240712
     # via -r requirements_dev.in
+types-urllib3==1.26.25.14
+    # via -r requirements_dev.in
 typing-extensions==4.12.2
     # via mypy
 urllib3==2.2.2

diff --git a/src/handler.py b/src/handler.py
@@ -76,7 +76,7 @@ def initialise_prom_metrics(operation: str):
         container_conf_name = operation[:-4].upper()
 
     initialise_prom_metrics_and_start_server(
-        config[container_conf_name]["PROM_METRIC_DEFS"], config[container_conf_name]["PROM_PORT"]
+        config[container_conf_name]["PROM_METRIC_DEFS"], config[container_conf_name]["PROM_PORT"]  # type: ignore
     )
 
 

diff --git a/src/library/flatten.py b/src/library/flatten.py
@@ -17,7 +17,7 @@
 from library.prometheus import set_prom_metric
 
 logger = getLogger("flatten")
-config_explode_elements = json.loads(config["SOLRIZE"]["EXPLODE_ELEMENTS"])
+config_explode_elements = json.loads(config["SOLRIZE"]["EXPLODE_ELEMENTS"])  # type: ignore
 
 
 class Flattener:

diff --git a/src/library/logger.py b/src/library/logger.py
@@ -3,7 +3,7 @@
 
 from constants.config import config
 
-loggers = {}
+loggers: dict[str, logging.Logger | None] = {}
 
 
 def getLogger(name="unknown"):

diff --git a/src/library/refresher.py b/src/library/refresher.py
@@ -10,7 +10,7 @@
 from azure.storage.blob import BlobServiceClient
 from psycopg2 import Error as DbError
 from requests.adapters import HTTPAdapter
-from requests.packages.urllib3.util.retry import Retry
+from urllib3.util.retry import Retry
 
 import library.db as db
 from constants.config import config

diff --git a/src/library/solrize.py b/src/library/solrize.py
@@ -15,7 +15,7 @@
 
 logger = getLogger("solrize")
 solr_cores = {}
-explode_elements = json.loads(config["SOLRIZE"]["EXPLODE_ELEMENTS"])
+explode_elements = json.loads(config["SOLRIZE"]["EXPLODE_ELEMENTS"])  # type: ignore
 
 
 def parse_status_code(error_str):