Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCENARIO: select items from a acorpus (#155) #577

Open
wants to merge 3 commits into
base: v7
Choose a base branch
from

Conversation

dwdw666
Copy link

@dwdw666 dwdw666 commented Apr 7, 2022

Co-authored-by: Clementlgz [email protected]
Co-authored-by: dylanbonelli [email protected]
Co-authored-by: corentinprp51 [email protected]
Co-authored-by: dwdw666 [email protected]

Content

creat a new feature


Checklist

Please check that your pull request is correct:

  • Each commit:
    • corresponds to a contribution that should be notified to users,
    • does not generate new errors or warnings at compile or test time,
    • must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
  • The title of a commit should:
    • begin with a contribution type
      • FEATURE for a behaviour allowing a user to do something new,
      • FIX for a behaviour which has been changed in order to meet user’s expectations,
      • SCENARIO for examples showing a given behaviour,
      • TEST when it concerns an acceptance test of a given behaviour,
      • PROCESS for a change in the way the software is built, tested, deployed,
      • DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
    • be followed by a colon (:) with one space after and no space before,
    • be followed by a title (written in English) as short, as user-centered and as explicit as possible
      • If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
      • If it is a fix, the title must describe the intended behavior (with should).
    • ends with a reference to the corresponding ticket with the following syntax:
      • (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
      • (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
      • (see #xx) otherwise,
  • Each committed line is:
    • useful (it would not work if removed)
      • if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
    • related to this very contribution (feature, fix...),
    • in English (with the exception of Gherkin scenarios in French and resulting steps),
    • without any typo in variable, class or function names,
    • correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

Co-authored-by: Clementlgz <[email protected]>
Co-authored-by: dylanbonelli <[email protected]>
Co-authored-by: corentinprp51 <[email protected]>
@corentinprp51
Copy link
Contributor

Après discussion orale, il faut donc réorganiser les commits pour en laisser uniquement trois seulement, un pour les scénario, un pour les tests et un pour l'implémentation. Pour ce faire avec votre branche existante, vous pouvez créer une branche temporaire puis sélectionner des commits via des cherry-picks (https://www.atlassian.com/fr/git/tutorials/cherry-pick)
Ensuite, vous pouvez supprimer la branche correspondant à la feature pour renommer la branche temporaire avec le nom correspondant à la branche supprimée pour que la pull request applique automatiquement les changements

)

Co-authored-by: dylanbonelli <[email protected]>
Co-authored-by: Clementlgz <[email protected]>
Co-authored-by: dwdw666 <[email protected]>
@dwdw666 dwdw666 marked this pull request as ready for review June 16, 2022 14:54
@dwdw666 dwdw666 requested a review from benel June 16, 2022 14:54
Co-authored-by: dwdw666 <[email protected]>
Co-authored-by: corentinprp51 <[email protected]>
Co-authored-by: dylanbonelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants