-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Add more logs and error handling for MW Mod support #1169
base: main
Are you sure you want to change the base?
Conversation
…r capturing in prepareBaseGameForModding function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I only have one comment
src/backend/utils.ts
Outdated
) | ||
} | ||
} catch (error) { | ||
if (error instanceof Error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this check, error will always be an instances of the Error class by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary to get the error type properly, without it we dont have access to error.message
.
But I changed it since in this case would be good to get the whole Error object.
…clearer permission error messages
…permission checks
copyRecursiveAsync
method.HOW TO TEST
Use the following Checklist if you have changed something on the Backend or Frontend: