-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Welcome modal update #1163
Changes from 9 commits
8f0687c
09e3b6c
b5cfaec
4022ba7
155aa16
884693d
64e0a58
27740b2
fa6e13b
68452be
ee9e966
d69bb64
dcd6504
c5739ef
2fad827
0aa1d6f
281de19
6d41c94
b2515a0
8c963ea
923bd48
060b839
925956d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,9 +1,13 @@ | ||||||
.languageSelector { | ||||||
margin: var(--space-lg) auto; | ||||||
margin: var(--space-lg) 0px; | ||||||
|
||||||
div { | ||||||
width: auto; | ||||||
} | ||||||
} | ||||||
|
||||||
.actionButton { | ||||||
margin: 0px auto; | ||||||
margin: var(--space-md) 0px; | ||||||
} | ||||||
.actionButton button { | ||||||
border-radius: var(--space-xs); | ||||||
|
@@ -13,12 +17,15 @@ | |||||
margin-left: var(--space-xs); | ||||||
} | ||||||
|
||||||
.welcomeTitle { | ||||||
color: var(--color-neutral-100); | ||||||
} | ||||||
.welcomeBody { | ||||||
margin-bottom: var(--space-lg); | ||||||
margin-bottom: var(--space-md); | ||||||
} | ||||||
|
||||||
.welcomeBodyTextContainer { | ||||||
color: var(--color-neutral-100); | ||||||
color: var(--color-neutral-400); | ||||||
} | ||||||
|
||||||
.welcomeBodyTextContainer > div { | ||||||
|
@@ -32,8 +39,38 @@ | |||||
.welcomeBodyTextContainer a:hover { | ||||||
color: var(--color-primary-300); | ||||||
transition: 0.2s; | ||||||
font-size: var(--font-size-md); | ||||||
} | ||||||
|
||||||
.text { | ||||||
font-weight: 400; | ||||||
} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We pretty much never have to set the specific typography in a component since we can reuse the styles from hp/ui There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to create a class to style a small piece of text differently because it was inheriting bold from its parent. I'll change it and use var instead the next time. |
||||||
|
||||||
.boldText { | ||||||
.textBold { | ||||||
font-weight: var(--bold); | ||||||
color: var(--color-neutral-100); | ||||||
} | ||||||
|
||||||
.diamondBlue { | ||||||
width: 10px; | ||||||
height: 10px; | ||||||
margin-right: 8px; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
.bulletPointIcon { | ||||||
list-style-type: none; | ||||||
} | ||||||
|
||||||
.bulletPointList { | ||||||
margin: 0; | ||||||
padding: 0; | ||||||
display: flex; | ||||||
flex-direction: column; | ||||||
align-items: flex-start; | ||||||
} | ||||||
|
||||||
.scrollableModal { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this class doesn't seem to be used anywhere |
||||||
max-height: 200px; | ||||||
overflow-y: auto; | ||||||
padding-right: 15px; | ||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ import { FlagPosition } from 'frontend/components/UI/LanguageSelector' | |
import { onboardingStore } from 'frontend/helpers/electronStores' | ||
import WelcomeStyles from './index.module.scss' | ||
import OnboardingStyles from '../index.module.scss' | ||
import { ReactComponent as DiamondBlue } from '/src/frontend/assets/diamond.svg' | ||
|
||
interface WelcomeProps { | ||
setScreen: React.Dispatch<React.SetStateAction<ONBOARDING_SCREEN>> | ||
|
@@ -18,61 +19,96 @@ const Welcome: React.FC<WelcomeProps> = function (props) { | |
return ( | ||
<> | ||
<Images.HyperPlayLogoColored className={OnboardingStyles.hpLogo} /> | ||
<h5> | ||
{t( | ||
'hyperplay.onboarding.welcome.title', | ||
'Welcome to HyperPlay Early Access!' | ||
)} | ||
</h5> | ||
<h6 className={WelcomeStyles.welcomeTitle}> | ||
{t('hyperplay.onboarding.welcome.titleIntro', 'Welcome to HyperPlay!')} | ||
</h6> | ||
<div className={`body ${WelcomeStyles.welcomeBodyTextContainer}`}> | ||
<div className={WelcomeStyles.boldText}> | ||
<div className={WelcomeStyles.text}> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.construction', | ||
`HyperPlay is under construction.` | ||
)} | ||
'hyperplay.onboarding.welcome.text.paragraphOne', | ||
`At HyperPlay, we’re building the next-generation game store | ||
for the future of gaming.` | ||
)}{' '} | ||
</div> | ||
<div> | ||
<div className={WelcomeStyles.text}> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.description', | ||
`HyperPlay is a game launcher and game store aggregator from the | ||
future. With HyperPlay, you can carry your wallet, tokens, and assets | ||
into every game. HyperPlay supports the entire library of the Epic | ||
Store, GOG, and our own HyperPlay store. By using HyperPlay, you agree | ||
to our` | ||
)}{' '} | ||
<a | ||
onClick={() => | ||
window.api.openExternalUrl( | ||
`https://www.hyperplay.xyz/terms-of-service` | ||
) | ||
} | ||
> | ||
{t('hyperplay.onboarding.terms', `Terms of Service.`)} | ||
</a> | ||
'hyperplay.onboarding.welcome.text.paragraphThree', | ||
`Seamlessly bring your wallet, tokens, | ||
and assets into every game while accessing | ||
the extensive libraries of the Epic Store, | ||
GOG, and our own HyperPlay Store, all in one place.` | ||
)} | ||
</div> | ||
<div> | ||
<div className={WelcomeStyles.textBold}> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bugs', | ||
`Please note that HyperPlay is a public alpha. Many features are still | ||
in development, and there will be bugs.` | ||
'hyperplay.onboarding.welcome.text.bulletTitle', | ||
`With HyperPlay, you can:` | ||
)} | ||
</div> | ||
<div> | ||
<ul | ||
className={`${WelcomeStyles.bulletPointIcon} ${WelcomeStyles.bulletPointList}`} | ||
> | ||
<li> | ||
<DiamondBlue className={WelcomeStyles.diamondBlue} /> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bulletPointOne', | ||
`Access a vast collection of 100+ on-chain enabled games` | ||
)} | ||
</li> | ||
<li> | ||
<DiamondBlue className={WelcomeStyles.diamondBlue} /> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bulletPointTwo', | ||
`Earn tokens, NFTs, and off-chain rewards by completing Quests` | ||
)} | ||
</li> | ||
<li> | ||
<DiamondBlue className={WelcomeStyles.diamondBlue} /> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bulletPointThree', | ||
`Play Epic and GOG games directly through HyperPlay` | ||
)} | ||
</li> | ||
<li> | ||
<DiamondBlue className={WelcomeStyles.diamondBlue} /> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bulletPointFour', | ||
`Install Steam (Windows version) on macOS with one easy click` | ||
)} | ||
</li> | ||
<li> | ||
<DiamondBlue className={WelcomeStyles.diamondBlue} /> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.bulletPointFive', | ||
`Run Windows games on macOS, Linux, and SteamDeck using our | ||
advanced` | ||
)}{' '} | ||
<a | ||
onClick={() => | ||
window.api.openExternalUrl( | ||
`https://docs.hyperplay.xyz/faq#q-what-operating-systems-are-supported` | ||
) | ||
} | ||
> | ||
Compatibility Layer (Beta) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be a translation string? |
||
</a> | ||
</li> | ||
</ul>{' '} | ||
</div> | ||
<div> | ||
{t( | ||
'hyperplay.onboarding.welcome.text.communityCTA_1', | ||
`We'd love your feedback and to have you join us in our` | ||
'hyperplay.onboarding.welcome.text.lastParagraph', | ||
`Currently in Beta, we highly value your feedback and | ||
encourage you to report any issues or suggestions in our` | ||
)}{' '} | ||
<a | ||
onClick={() => | ||
window.api.openExternalUrl(`https://discord.gg/hyperplay`) | ||
} | ||
> | ||
{t('hyperplay.discordApp', `Discord`)} | ||
{t('hyperplay.discordAppLink', `Discord Community.`)} | ||
</a>{' '} | ||
{t( | ||
'hyperplay.onboarding.welcome.text.communityCTA_2', | ||
`community. Together, let's shape the future of gaming!` | ||
)} | ||
</div> | ||
</div> | ||
<div className={WelcomeStyles.languageSelector}> | ||
|
@@ -84,6 +120,7 @@ const Welcome: React.FC<WelcomeProps> = function (props) { | |
onboardingStore.set('completedEarlyAccess', true) | ||
props.setScreen(ONBOARDING_SCREEN.ANALYTICS) | ||
}} | ||
type="secondary" | ||
> | ||
{t('button.continue', 'Continue')}{' '} | ||
<FontAwesomeIcon | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? It seems odd to me that we would set the font size instead of using a typography style, especially on hover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already in the file, I only changed it from lg to md;