Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Support quests for non-hp games #1097

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 2, 2024

Summary

Support quests for games in external game stores.

Open the overlay for these games if a quest exists for it, and redirect to the appropriate store url if the game is not in the user's library.

Testing

Search for test Fortnite quest to test

@BrettCleary BrettCleary self-assigned this Oct 2, 2024
@flavioislima flavioislima mentioned this pull request Oct 4, 2024
4 tasks
@flavioislima flavioislima force-pushed the feat/support_external_game_quests branch from f3d80db to 00c39b3 Compare October 7, 2024 19:23
@BrettCleary BrettCleary marked this pull request as ready for review October 8, 2024 18:46
@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 8, 2024
@nyghtstalker nyghtstalker self-requested a review October 10, 2024 17:40
@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 10, 2024
@nyghtstalker
Copy link

The only quest/game I was able to test was Fortnite. I can confirm that I am seeing the overlay appear when launching the game.

  1. Unable to claim the reward once the counter completes. After relaunch the button is clickable but gives an error.

  2. Claimed page still shows the quest content on the right side. Normally that side is blank. I don't think this is a blocker but would be good to get this fixed if it is not intended.

image
image
image

@BrettCleary BrettCleary merged commit 58dffe6 into main Oct 10, 2024
10 checks passed
@BrettCleary BrettCleary deleted the feat/support_external_game_quests branch October 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants