Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak JS tests #39

Open
hsmett opened this issue Jun 12, 2020 · 1 comment
Open

Weak JS tests #39

hsmett opened this issue Jun 12, 2020 · 1 comment
Assignees
@joehybird

Comments

@hsmett
Copy link
Member

hsmett commented Jun 12, 2020

https://app.circleci.com/pipelines/github/HybirdCorp/creme_crm/148/workflows/fce73511-18a3-4aa1-a4a4-2543e51eb42c/jobs/556/steps

Firefox 77.0.0 (Linux 0.0.0) creme.widget.frame.js creme.widget.Frame.create (url, overlay shown, async, error) FAILED
	has overlay
	Expected: 0
	Actual: 1
	applyCurrent/<@node_modules/qunitjs/qunit/qunit.js:1907:13
	assertOverlayState@creme/creme_core/static/creme_core/js/tests/dialog/qunit-dialog-mixin.js:213:18
	@creme/creme_core/static/creme_core/js/tests/widgets/frame.js:216:14
 
	overlay status:undefined
	applyCurrent/<@node_modules/qunitjs/qunit/qunit.js:1907:13
	assertOverlayState@creme/creme_core/static/creme_core/js/tests/dialog/qunit-dialog-mixin.js:214:18
	@creme/creme_core/static/creme_core/js/tests/widgets/frame.js:216:14
 
	overlay isactive
	Expected: false
	Actual: true
	applyCurrent/<@node_modules/qunitjs/qunit/qunit.js:1907:13
	assertOverlayState@creme/creme_core/static/creme_core/js/tests/dialog/qunit-dialog-mixin.js:215:18
	@creme/creme_core/static/creme_core/js/tests/widgets/frame.js:216:14
@hsmett
Copy link
Member Author

hsmett commented Jun 21, 2020

https://app.circleci.com/pipelines/github/HybirdCorp/creme_crm/225/workflows/8ef9f562-bcfb-4b9e-9bd4-8c31427449c4/jobs/1004/parallel-runs/0/steps/0-116

joehybird added a commit that referenced this issue Jul 24, 2020
@joehybird
Refs #64 Handle html entities like '&#39;' in dialog title
7549806
joehybird added a commit that referenced this issue Jul 24, 2020
@joehybird
Refs #64 Handle html entities like '&#39;' in dialog title
2b30f68
genglert added a commit that referenced this issue Jan 29, 2021
@genglert
[ci skip]
00adf78 
TODO: changelog
TODO: complete

TODO: fix ContentType.__str__() (remove label)

TODO: test creme_uninstall
TODO: re-activate eslint (see .githooks/pre-commit & .githooks/pre-push )

Django's version is now "3.0".
Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
genglert added a commit that referenced this issue Feb 2, 2021
@genglert
Django's version is now "3.0".
448451a 
TODO: re-activate eslint (see .githooks/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 8, 2021
@genglert
Django's version is now "3.0".
bb90d42 
TODO: re-activate eslint (see .githooks/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 10, 2021
@genglert
Django's version is now "3.0".
f553975 
TODO: re-activate eslint (see .githooks/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 11, 2021
@genglert
Django's version is now "3.0". TODO: re-activate eslint (see .githook…
2a823ec 
…s/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 18, 2021
@genglert
Django's version is now "3.0". TODO: re-activate eslint (see .githook…
30d69d2 
…s/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 18, 2021
@genglert
Django's version is now "3.0". TODO: re-activate eslint (see .githook…
d83b664 
…s/pre-commit & .githooks/pre-push )

Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 22, 2021
@genglert
Django's version is now "3.0".
3b7c478 
Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
genglert added a commit that referenced this issue Feb 22, 2021
@genglert
Django's version is now "3.0".
3f1f435 
Notes:
 - django.utils.encoding.force_text() => force_str()
 - django.utils.html.escape() converts now ' to &#x27; instead of &#39;.
 - django.utils.http.urlquote() => urllib.parse.quote()
 - django.utils.http.is_safe_url() => url_has_allowed_host_and_scheme()
 - Use the old ContentType__str__() method.
 - The decorator @xframe_options_sameorigin has been used on views which are designed to be displayed in <iframe> (HTML bodies of emails).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehybird joehybird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsmett @joehybird