Skip to content

Commit

Permalink
Refs #64 Handle html entities like ''' in dialog title
Browse files Browse the repository at this point in the history
  • Loading branch information
joehybird committed Jul 24, 2020
1 parent 8a6edd2 commit 2b30f68
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ creme.dialog.Dialog = creme.component.Component.sub({
return this._dialog.dialog('option', 'title');
}

this._dialog.dialog('option', 'title', String(title).unescapeHTML());
this._dialog.dialog('option', 'title', String(title).decodeHTMLEntities());
return this;
},

Expand Down Expand Up @@ -572,7 +572,7 @@ creme.dialog.Dialog = creme.component.Component.sub({
var draggable = is_framescroll ? options.draggable : false;
var width = options.minWidth > 0 ? Math.max(options.minWidth, options.width) : options.width;
var height = options.minHeight > 0 ? Math.max(options.minHeight, options.height) : options.height;
var title = options.title ? String(options.title).unescapeHTML() : options.title;
var title = options.title ? String(options.title).decodeHTMLEntities() : options.title;

this._dialog = content.dialog({buttons: Object.values(buttons),
title: title,
Expand Down

0 comments on commit 2b30f68

Please sign in to comment.