Skip to content

Commit

Permalink
create_disk.sh: stop setting immutable bit on sysroot
Browse files Browse the repository at this point in the history
Nowadays, the sysroot is mounted read-only anyway, so it seems
unnecessary to also slap on an immutable bit. Note this is distinct from
the deployment root immutable bit.

Prompted by the fact that when moving to osbuild, we don't want to have
to care about this and try to replicate it.
  • Loading branch information
jlebon committed Jan 10, 2024
1 parent 189d72c commit e693d65
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/create_disk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -531,15 +531,6 @@ if [[ ${secure_execution} -eq 1 ]] && [[ ! -e /dev/disk/by-id/virtio-genprotimg
fi
touch $rootfs/boot/ignition.firstboot

# Finally, add the immutable bit to the physical root; we don't
# expect people to be creating anything there. A use case for
# OSTree in general is to support installing *inside* the existing
# root of a deployed OS, so OSTree doesn't do this by default, but
# we have no reason not to enable it here. Administrators should
# generally expect that state data is in /etc and /var; if anything
# else is in /sysroot it's probably by accident.
chattr +i $rootfs

fstrim -a -v
# Ensure the filesystem journals are flushed
for fs in $rootfs/boot $rootfs; do
Expand Down

0 comments on commit e693d65

Please sign in to comment.