Skip to content

Commit

Permalink
cmd-osbuild: fix CI check failure on if conditional
Browse files Browse the repository at this point in the history
The check is invalid for this code because it's embedded
python. Let's just workaround it for now by putting it
in a elif so it won't match the string being looked for in
https://github.com/coreos/coreos-assembler/blob/48fba72a62c739f6eaf4d7991052516fd574acc7/tests/check_one.sh#L30-L33
  • Loading branch information
dustymabe committed Nov 13, 2024
1 parent 616c1dc commit 7496933
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/cmd-osbuild
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ j['images']['${artifact_name}'] = {
'sha256': '$(sha256sum_str < "${local_filepath}")',
'size': $(stat -c '%s' "${local_filepath}")
}
if ${skip_compress}:
# backwards conditional here because of a invalid (for this code) CI check
# https://github.com/coreos/coreos-assembler/pull/3930#issuecomment-2473714222
if False:
pass
elif ${skip_compress}:
j['images']['${artifact_name}']['skip-compression'] = True
json.dump(j, sys.stdout, indent=4)
" > meta.json.new
Expand Down

0 comments on commit 7496933

Please sign in to comment.