-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the kurtosis package to run kylin parachain local #9
feat: implement the kurtosis package to run kylin parachain local #9
Conversation
parachain/kylin.star
Outdated
@@ -0,0 +1,16 @@ | |||
def kylin_run(plan,args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function name should always be a verb (run_<chain/node name>).
parachain/kylin.star
Outdated
def run_kylin(plan,args): | ||
|
||
exec_command = ["--base-path=/kylin/data","--chain=dev","--ws-external","--rpc-external","--rpc-cors=all","--name=parachain-2010-0","--collator","--rpc-methods=unsafe","--force-authoring","--execution=wasm","--alice","--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8","--","--chain=/app/rococo-local.json","--execution=wasm"] | ||
parachain = plan.add_service( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused variable
parachain/kylin.star
Outdated
@@ -0,0 +1,16 @@ | |||
def run_kylin(plan,args): | |||
|
|||
exec_command = ["--base-path=/kylin/data","--chain=dev","--ws-external","--rpc-external","--rpc-cors=all","--name=parachain-2010-0","--collator","--rpc-methods=unsafe","--force-authoring","--execution=wasm","--alice","--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8","--","--chain=/app/rococo-local.json","--execution=wasm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format this line propely
parachain/kylin.star
Outdated
@@ -0,0 +1,15 @@ | |||
def run_kylin(plan, args): | |||
exec_command = ["--base-path=/kylin/data", "--chain=dev", "--ws-external", "--rpc-external", "--rpc-cors=all", "--name=parachain-2010-0", "--collator", "--rpc-methods=unsafe", "--force-authoring", "--execution=wasm", "--alice", "--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8", "--", "--chain=/app/rococo-local.json", "--execution=wasm"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format this
Description:
implement the kurtosis package to run kylin parachain local
Commit Message
feat: implement the kurtosis package to run kylin parachain local
see the guidelines for commit messages.
Checklist: