Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the kurtosis package to run kylin parachain local #9

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

shanithkk
Copy link
Collaborator

@shanithkk shanithkk commented Oct 27, 2023

Description:

implement the kurtosis package to run kylin parachain local

Commit Message

feat: implement the kurtosis package to run kylin parachain local

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@@ -0,0 +1,16 @@
def kylin_run(plan,args):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name should always be a verb (run_<chain/node name>).

def run_kylin(plan,args):

exec_command = ["--base-path=/kylin/data","--chain=dev","--ws-external","--rpc-external","--rpc-cors=all","--name=parachain-2010-0","--collator","--rpc-methods=unsafe","--force-authoring","--execution=wasm","--alice","--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8","--","--chain=/app/rococo-local.json","--execution=wasm"]
parachain = plan.add_service(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable

@@ -0,0 +1,16 @@
def run_kylin(plan,args):

exec_command = ["--base-path=/kylin/data","--chain=dev","--ws-external","--rpc-external","--rpc-cors=all","--name=parachain-2010-0","--collator","--rpc-methods=unsafe","--force-authoring","--execution=wasm","--alice","--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8","--","--chain=/app/rococo-local.json","--execution=wasm"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format this line propely

@@ -0,0 +1,15 @@
def run_kylin(plan, args):
exec_command = ["--base-path=/kylin/data", "--chain=dev", "--ws-external", "--rpc-external", "--rpc-cors=all", "--name=parachain-2010-0", "--collator", "--rpc-methods=unsafe", "--force-authoring", "--execution=wasm", "--alice", "--node-key=52194369e4c881e4157b74fd00dff4241e50b8100b823273e25c868a70e5cde8", "--", "--chain=/app/rococo-local.json", "--execution=wasm"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format this

@shreyasbhat0 shreyasbhat0 merged commit ca210b1 into main Oct 30, 2023
1 check passed
@shreyasbhat0 shreyasbhat0 deleted the DIVE-198-Localnet-setup-for-Kylin-Polkadot branch October 30, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants