Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue when the node type is anything which is not valid the still node in getting started as full node #162

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

abhiyana
Copy link
Contributor

…node still runs

Description:

Commit Message

fix: fix issue when the node type is anything which is not valid the still node in getting started as full node

see the guidelines for commit messages.

Changelog Entry

If the node-type in local.json is not valid the starlark package execution will fail

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@abhiyana abhiyana requested a review from Mr-Nobody21 December 14, 2023 08:20
@Mr-Nobody21 Mr-Nobody21 merged commit f0bdb36 into main Dec 14, 2023
1 check passed
@shanithkk shanithkk deleted the refactor-service-config-development branch January 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants