Add feature to ignore parsing errors when doing nested interpretation #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErrorHandlingStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off the
ContextConfigurationimmutable object I added in #1195.Nested interpretation is cancerous.
I can write an entirely well-formatted template:
And get
SYNTAX_ERRORs ifmy_varis{% if.Also, disabled tags which are attempted to be rendered in nested interpretation produce errors. It's probably better to just ignore the tags.
This functionality is behind the feature
IGNORE_NESTED_INTERPRETATION_PARSE_ERRORS, which is disabled by default.This PR accomplishes what #1151 aims to do, plus the added bonus of ignoring any parsing errors when using nested interpretation.