Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in dictsort. #1180

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix NPE in dictsort. #1180

merged 1 commit into from
May 13, 2024

Conversation

hs-lsong
Copy link
Collaborator

@hs-lsong hs-lsong commented May 9, 2024

Some map may have null values or keys. Let's skip them when sorting -- treated them as equal to anything.

@hs-lsong hs-lsong requested a review from jasmith-hs May 9, 2024 13:55
@hs-lsong hs-lsong merged commit ee49945 into master May 13, 2024
5 checks passed
@hs-lsong hs-lsong deleted the fix-npe-in-dictsort branch May 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant