-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support for update/delete #6
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR. It's a very nice implementation. A few comments:
|
Regarding the call to closeHTable, I think you can leave it as is now to achieve a sure flush. Thanks. |
@@ -304,3 +304,6 @@ case class BulkLoadIntoTableCommand( | |||
override def output = Nil | |||
} | |||
|
|||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i should revert changes of this file
i have tested this patch in my own cluster, and the functionality is ok. |
@@ -19,13 +19,14 @@ package org.apache.spark.sql.hbase | |||
import org.apache.hadoop.conf.Configuration | |||
import org.apache.hadoop.hbase.util.Bytes | |||
import org.apache.hadoop.hbase.{HBaseConfiguration, _} | |||
import org.apache.hadoop.hbase.client.{Get, HTable, Put, Result, Scan} | |||
import org.apache.hadoop.hbase.client._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not use wildcard for import. follow the coding convention
todos: