Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validations when setting direct_otp #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip validations when setting direct_otp #179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e00d5a9
Skip validations when setting direct_otp
jmschneider Sep 9, 2019
a460101
Update DB directly
jmschneider Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/two_factor_authentication/models/two_factor_authenticatable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def need_two_factor_authentication?(request)
end

def send_new_otp(options = {})
create_direct_otp options
create_direct_otp(options)
send_two_factor_authentication_code(direct_otp)
end

Expand Down Expand Up @@ -101,7 +101,7 @@ def generate_totp_secret
def create_direct_otp(options = {})
# Create a new random OTP and store it in the database
digits = options[:length] || self.class.direct_otp_length || 6
update_attributes(
update_columns(
direct_otp: random_base10(digits),
direct_otp_sent_at: Time.now.utc
)
Expand All @@ -122,7 +122,10 @@ def direct_otp_expired?
end

def clear_direct_otp
update_attributes(direct_otp: nil, direct_otp_sent_at: nil)
update_columns(
direct_otp: nil,
direct_otp_sent_at: nil
)
end
end

Expand Down