Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.2 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Ruby 3.2 #7

wants to merge 1 commit into from

Conversation

maneyko
Copy link

@maneyko maneyko commented Feb 23, 2024

File.exists? and Dir.exists? have been removed in Ruby 3.2 in favor of File.exist? and Dir.exist?, respectively.

Both File.exist? and Dir.exist? have been around since Ruby 1.9.0, so backwards compatibility is not a concern here.

@baburdick
Copy link

It's actually exist? that you want to demonstrate historical support for, not exists? which is being removed. You're switching to exist?. So you want to demonstrate this switch is valid going back to some impressively old implementation, right? (e.g. https://github.com/ruby/ruby/blob/v1_9_0_0/file.c#L4445 and https://github.com/ruby/ruby/blob/v1_9_0_0/dir.c#L1906).

@baburdick
Copy link

What options do we have here for CI, so we can validate the test suite is sufficient and passes? GitHub Actions? CircleCI? Team City? Etc.?

@albertosaurus
Copy link

GitHub Actions is what everyone uses.

@maneyko
Copy link
Author

maneyko commented Mar 6, 2024

Ah right. Thanks for catching that. I've updated the PR description with the correct references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants