-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename indexes and constraints #11
Open
baburdick
wants to merge
2
commits into
master
Choose a base branch
from
5202_rename_indexes_and_constraints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_and_constraints mod: port changes to renamed files * origin/master: (129 commits) v2.4.1: Fix push mistake for #9 'origin/support_triggers' Update README.markdown Updated documentation. Cleaned up comments. Finished implementing support for triggers. Implement support for triggers. v2.3.1: Fix inconsistent gemspec Add gemspec belatedly Add README docs, attribution; update copyright Revise RDoc, formatting Supply missing RDoc; revise RDoc, formatting Add missing coverage Explicit test for no-replace option. Improved code alignment. Re-arranged code so the private methods are at the bottom. Initial support for creating database functions. Remove unnecessary RSpec constraint Change default value of option ensure_role_set to false Use the PgSaurus name Bump version to side-step rubygems issue caused by mistaken push New versioning for new name; revise gemspec authors Implement keep_default_role method Add MetricFu data Update README, copyright Update license Add missing doc Update README Implement generator pg_power:install Impelement Migraton.set_role method Task 1090 renamed to PgSaurus Remove note in Gemfile implement create_schema_if_not_exists Update RSpec; address deprecation warnings Return only public schema tables for non-postgres users Fixed duplicatiion of tables with schemas Fixed index_name_exists? Escape view defenition with inline document syntax #49 Add test cases to ensure options can be frozen Hash Duplicate options param in methods with side-effect to the options param Task 13294 fixed specs for Postgres 9.3 Add metric_fu results Adjust SimpleCov threshold Handle line length critiques; revise formatting Handle uncommunicative variable name critique Fix duplicate method call critiques; revise formatting Fix metric_fu configuration Revise test descriptions, formatting Add SimpleCov threshold support test coverage now is 97%, fixed drop_extension method for postgres adapter Fix typos, formatting Fix typo Update travis settings Update README with note about rails 3 Address deprecation warnings Make specs pass with rails4 Build schema.rb with rails4 Make test migrations pass Make add_index method work with Rails4 Use Rails4 A little love made to README.md. Make #tables method return public tables without schema prefix Make specs pass with postgresql 9.3 Get rid of unused fk_options variable Address yard warnings Add missing docs Make connection.tables method return tables from all schemas. Issue #18 Update Travis config: remove ree, 1.8.7, 1.9.2. Add 2.0.0, 2.1.0 Escape extension name with double quotes. Update the extension migration to test it. wrap extension name in quotes to support uuid-ossp extension Fix gemspec authors v1.6.3 Update to .ruby-gemset from deprecated .rvmrc; update code metric tools Use HTTPS for gem sources Add license to be generated in gemspec Move rspec to development dependency removed invert_drop_view method hooked tables method in schema dumper reverted change to database.yml added comments, specs, some fixes hooked new code into ar::schema_dumper started adding support for view creation Support for index comments Get the schema dumper working. Handle types of expression parameters This adds support for literal strings in functions. Cleaned up Gemfile and README. Fixed specs where simplecov isn't loaded. Adding simplecov test coverage measurements. Updating README with instructions for installing contrib packages via Mac Ports Don't break during schema dump when run against Postgresql < 9.1 which doesn't have pg_extension system catalog Use more common extensions, postgresql-contrib requirement in README, ability to specify index access methods Fixed misusage of schema parameter instead of schema_name an attemp to make Travis CI happy Fixed a few typos and imporved test coverage Documentation and gemspec Specs for schema_dumper which effectively test the whole extensions feature command_recordeer for create_extension and drop_extension Organization of hooks to properly dump loaded extension modules Create/drop extensions support Update TODO in README to reflect current state Check for existing index was added to `add_index`. ...
Possibly related to #7 |
@albertosaurus mind taking a look at this when you have a chance |
@dlionikis rename index still needs to be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brushing up @greyblake's 2012 attempt at this. Tests pass. But it is likely incomplete.