code review fixes

HornsAndHooves · Aug 22, 2022 · ee534f3 · ee534f3
1 parent 870a6b0
commit ee534f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/moribus/extensions/has_current_extension.rb b/lib/moribus/extensions/has_current_extension.rb
@@ -26,6 +26,9 @@ def remove_target!(*)
         end
       end
 
+      # Is the record has a column with name `updated_at`
+      #
+      # @return [Boolean]
       private def has_updated_at_column?
         target.class.column_names.include?("updated_at")
       end

diff --git a/spec/moribus/extensions/has_current_extension_spec.rb b/spec/moribus/extensions/has_current_extension_spec.rb
@@ -38,7 +38,7 @@ class SpecCustomer < MoribusSpecModel(spec_status_id: :integer)
       it "sets 'is_current' flag of overridden record to false for new record" do
         old_info = customer.spec_customer_info
         customer.spec_customer_info = SpecCustomerInfo.new
-        expect(old_info.is_current).to be_falsey
+        expect(old_info.is_current).to be false
       end
 
       it "sets 'is_current' flag updates updated_at column" do