Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert setup.cfg To pyproject.toml #391

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

TimothyWillard
Copy link
Contributor

Describe your changes.

This PR converts gempyor's setup.cfg to a more modern pyproject.toml. Also adds missing h5py dependency and specifies dask as dask[dataframe]. The conversion should have no user facing consequences, but the dependencies will address prior warnings/issues.

What does your pull request address? Tag relevant issues.

This pull request addresses:

Updated to the more modern `pyproject.toml` format per GH-314. Edit
`venv` in `.gitignore` to be a bit more generic for developer ease.
Fixes GH-390 with `dask[dataframe]` and GH-315 with `h5py`.
`gempyor` is not stable for 3.12/13 quite yet, restriction just
formalizes that.
@TimothyWillard TimothyWillard added gempyor Concerns the Python core. quick issue Short or easy fix. installation Relating to installation / upgrade / migration. dependency For issues with package dependencies. labels Nov 8, 2024
Copy link
Contributor

@pearsonca pearsonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor amendment proposed, otherwise seems fine. haven't double checked that it "just works" as a swap

flepimop/gempyor_pkg/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jcblemai jcblemai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think for gempyor author we could get a more updated author list now if we need it. Also not necessarily in this pr.

@jcblemai
Copy link
Collaborator

jcblemai commented Nov 8, 2024

homepage should probably be flepimop.org

@TimothyWillard
Copy link
Contributor Author

lgtm. I think for gempyor author we could get a more updated author list now if we need it. Also not necessarily in this pr.

Yeah, typically the active group of developers is listed in maintainers and authors is static list of the original developers. But that's not a hard rule and agree and another PR.

@TimothyWillard TimothyWillard merged commit c5f4835 into dev Nov 8, 2024
2 checks passed
@TimothyWillard TimothyWillard deleted the feature/314/pyproject-toml branch November 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency For issues with package dependencies. gempyor Concerns the Python core. installation Relating to installation / upgrade / migration. quick issue Short or easy fix.
Projects
None yet
5 participants