-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert setup.cfg
To pyproject.toml
#391
Conversation
Updated to the more modern `pyproject.toml` format per GH-314. Edit `venv` in `.gitignore` to be a bit more generic for developer ease.
`gempyor` is not stable for 3.12/13 quite yet, restriction just formalizes that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor amendment proposed, otherwise seems fine. haven't double checked that it "just works" as a swap
Co-authored-by: Carl A. B. Pearson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I think for gempyor author we could get a more updated author list now if we need it. Also not necessarily in this pr.
homepage should probably be flepimop.org |
Yeah, typically the active group of developers is listed in |
Per @jcblemai suggestion.
Describe your changes.
This PR converts
gempyor
'ssetup.cfg
to a more modernpyproject.toml
. Also adds missingh5py
dependency and specifiesdask
asdask[dataframe]
. The conversion should have no user facing consequences, but the dependencies will address prior warnings/issues.What does your pull request address? Tag relevant issues.
This pull request addresses:
setup.cfg
topyproject.toml
#314dask
Dependency Forgempyor
#390h5py
Dependency Forgempyor
#315