Documentation GH Action And PR Template Updates #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change trigger from cron to on merge to either `main` or `documentation-gitbook` or push to `documentation-gitbook`. * Change assignees to reviewers. * Change name slightly to be human readable.
Add a section to the PR template that explicitly asks users to describe any user interface changes.
TimothyWillard
requested review from
emprzy,
pearsonca,
jcblemai,
alsnhll and
saraloo
pearsonca
requested changes
Oct 28, 2024
Add prompt for where said changes to UI are documented per @pearsonca's suggestion. Co-authored-by: Carl A. B. Pearson <[email protected]>
TimothyWillard
force-pushed
the
GH-363/documentation-pull-request-updates
branch
from
e669e87 to
56eb114
Compare
TimothyWillard
added
documentation
jcblemai
approved these changes
Oct 28, 2024
pearsonca
reviewed
Oct 28, 2024
pearsonca
approved these changes
Oct 29, 2024
emprzy
approved these changes
Oct 30, 2024
|
Thanks Tim - this is good to me. Just confirming, as in other PRs this would always require two reviewers? Hopefully that doesn't hold up merges but will try to keep on top of things. |
saraloo
approved these changes
Nov 4, 2024
Yes, that's correct. The 2 reviewers for a PR is a repository setting and cannot be changed on a per PR basis. |
emprzy
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
mainordocumentation-gitbookor 2) a push todocumentation-gitbook. This will make syncing the GitBook more responsive to keep the two sources of documentation more up to date with one another.Does this pull request make any user interface changes? If so please describe.
n/a
What does your pull request address? Tag relevant issues.
This pull request addresses GH-363.
Tag relevant team members.
@alsnhll @emprzy @jcblemai @pearsonca @saraloo