Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #240 #251

Merged
merged 2 commits into from
Jul 14, 2024
Merged

fix #240 #251

merged 2 commits into from
Jul 14, 2024

Conversation

jcblemai
Copy link
Collaborator

I'm sure there was a reason for this but could not recall it. Fix #240

TimothyWillard
TimothyWillard approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@TimothyWillard TimothyWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it would be nice to get unit tests for this behavior, but I don't want that to hold up this PR since this currently blocks the ability to run the sample configs.

saraloo
saraloo approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@saraloo saraloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@saraloo saraloo merged commit 27c7a5b into main Jul 14, 2024
1 check passed
@jcblemai jcblemai deleted the fix/inference_all_hardcoded branch July 15, 2024 12:26
jcblemai pushed a commit that referenced this pull request Oct 3, 2024
@saraloo
Merge pull request #251 from HopkinsIDD/fix/inference_all_hardcoded
cf1d8c4 
fix #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraloo saraloo saraloo approved these changes

@TimothyWillard TimothyWillard TimothyWillard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in inference_slot when the prefix is not "inference_all"
3 participants
@jcblemai @TimothyWillard @saraloo