Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes to errors in aggregation stuff #241

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

saraloo
Copy link
Contributor

@saraloo saraloo commented Jun 24, 2024

Just double checking the example inference config works - fixing a few errors in it. Changed the scenarios in the config itself - see issue #240 that requires some more thought, but quick fix here for now.

@saraloo saraloo requested review from jcblemai and emprzy June 24, 2024 19:08
Copy link
Collaborator

@emprzy emprzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sara!

Copy link
Collaborator

@jcblemai jcblemai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Sara

@jcblemai jcblemai merged commit 530afbc into main Jun 25, 2024
1 check passed
@jcblemai jcblemai deleted the fix-sample-configs branch June 25, 2024 16:35
jcblemai added a commit that referenced this pull request Oct 3, 2024
Some small fixes to errors in aggregation stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants