Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sep seeding and ic #204

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Sep seeding and ic #204

merged 5 commits into from
Apr 16, 2024

Conversation

fang19911030
Copy link
Collaborator

In the old code, seeding and initial_conditions are in the same python file, which is also true for the corresponding unit test. This PR create corresponding unit test file for seeding and initial_conditions.

@fang19911030 fang19911030 requested review from jcblemai and kjsato April 12, 2024 15:05
jcblemai
jcblemai previously approved these changes Apr 15, 2024
Copy link
Collaborator

@jcblemai jcblemai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, and very useful, thank you

Copy link
Contributor

@kjsato kjsato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates, I will approve it

@jcblemai
Copy link
Collaborator

🙏🏻

@jcblemai jcblemai merged commit 8d49518 into main Apr 16, 2024
1 check passed
@jcblemai jcblemai deleted the sep_seeding_and_ic branch April 16, 2024 14:01
jcblemai added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants