Updating steps_source.py and utils.py

There were not that many changes in the final batch of error improvements, so I went ahead and lumped them in with batch two.
HopkinsIDD · Nov 20, 2024 · 8fe918a · 8fe918a
1 parent e5772c7
commit 8fe918a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/flepimop/gempyor_pkg/src/gempyor/steps_source.py b/flepimop/gempyor_pkg/src/gempyor/steps_source.py
@@ -278,8 +278,11 @@ def steps_SEIR_nb(
                 print("  ", states_current[comp].max())
 
         if (states_current.min() < 0) or (states_current.max() > 10**10):
-            print((states_current.min() < 0), (states_current.max() > 10**10))
-            raise ValueError(f"Overflow error. Too small ?. Too large ?")
+            raise ValueError(
+                f"State values are outside the valid range. "
+                f"Minimum value: '{states_current.min()}', Maximum value: '{states_current.max()}'. "
+                f"Valid range is between 0 and {10**10}."
+            )
 
     return states, states_daily_incid
 

diff --git a/flepimop/gempyor_pkg/src/gempyor/utils.py b/flepimop/gempyor_pkg/src/gempyor/utils.py
@@ -47,7 +47,7 @@ def write_df(
         None
 
     Raises:
-        ValueError: The given output extension is not supported yet.
+        NotImplementedError: The given output extension is not supported yet.
     """
     # Decipher the path given
     fname = fname.decode() if isinstance(fname, bytes) else fname
@@ -82,7 +82,7 @@ def read_df(
         A pandas DataFrame parsed from the file given.
 
     Raises:
-        ValueError: The given output extension is not supported yet.
+        NotImplementedError: The given output extension is not supported yet.
     """
     # Decipher the path given
     fname = fname.decode() if isinstance(fname, bytes) else fname