Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 2.0.0 #193322

Merged
merged 2 commits into from
Oct 10, 2024
Merged

deno 2.0.0 #193322

merged 2 commits into from
Oct 10, 2024

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Oct 9, 2024

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Oct 9, 2024
@ZhongRuoyu ZhongRuoyu force-pushed the bump-deno-2.0.0 branch 3 times, most recently from 7b0adfb to 8e2041b Compare October 9, 2024 12:31
@nathanwhit
Copy link
Contributor

nathanwhit commented Oct 9, 2024

(Deno maintainer here 👋) It looks like there's an issue building with the new version of the llvm formula. Try using llvm@18 instead of llvm throughout the formula.

cc @ZhongRuoyu

@chenrui333
Copy link
Member

(Deno maintainer here 👋) It looks like there's an issue building with the new version of the llvm formula. Try using llvm@18 instead of llvm throughout the formula.

cc @ZhongRuoyu

@nathanwhit 👋 do you have any issue tracking the llvm 19 support? Thanks!

@nathanwhit
Copy link
Contributor

nathanwhit commented Oct 9, 2024

Looks like a few references to the llvm formula left:

clang_version = Formula["llvm"].version.major

ENV["CLANG_BASE_PATH"] = Formula["llvm"].prefix

ENV.remove "HOMEBREW_LIBRARY_PATHS", Formula["llvm"].opt_lib

@nathanwhit 👋 do you have any issue tracking the llvm 19 support? Thanks!

@chenrui333 We don't have an issue open for it, but it should be fixed after this PR: denoland/rusty_v8#1639
So likely we can go back to the LLVM 19 formula on the next Deno release

Co-authored-by: Ruoyu Zhong <[email protected]>
@chenrui333
Copy link
Member

Sounds good, thanks @nathanwhit!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 10, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 10, 2024 02:33
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 10, 2024
Merged via the queue into master with commit 28a7c70 Oct 10, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-deno-2.0.0 branch October 10, 2024 02:39
@ZhongRuoyu
Copy link
Member

Thanks @nathanwhit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants