Merge pull request #145 from HoI4-LOTRMod-Team/dev

Dev

.github/workflows/create_release.yml

@@ -32,10 +32,6 @@ jobs:
         run: |
           # Read the contents of patch_notes.txt
           patch_notes=$(cat patch_notes.txt)
-          # Escape newline characters to be compatible with GitHub Actions output
-          patch_notes="${patch_notes//'%'/'%25'}"
-          patch_notes="${patch_notes//$'\n'/'%0A'}"
-          patch_notes="${patch_notes//$'\r'/'%0D'}"
           echo "patch_notes=$patch_notes" >> $GITHUB_OUTPUT
 
       - name: Create Release

README.md

@@ -1,10 +1,33 @@
 Github repository for the [*Lord of the Rings Mod*](https://steamcommunity.com/sharedfiles/filedetails/?id=1314446921) for *Hearts of Iron IV*.
 
+![img](https://steamuserimages-a.akamaihd.net/ugc/2014835196556028806/C9F439399E0C57D2F15CBF9E0196E657EB6D2DEC/?imw=637&imh=358&ima=fit&impolicy=Letterbox&imcolor=%23000000&letterbox=true)
+
+## Links
 
 Steam Page: https://steamcommunity.com/sharedfiles/filedetails/?id=1314446921
+
 Discord Server: https://discord.gg/XdQ3GbACPW
 
-Want to make a contribution? Feel free to open a pull-request or get in touch!
+## Download
+
+The easiest way to download the mod is through the [Steam Workshop page](https://steamcommunity.com/sharedfiles/filedetails/?id=1314446921).
+
+If you don't have the steam version of HoI4 or want to use an older version of the mod, you can download it from our [Github Releases Page](https://github.com/HoI4-LOTRMod-Team/HoI4-LotrMod/releases). If you want to develop/contribute or access WIP content, you can simply clone this repository.
+
+Note that downloading the mod from sources other than the Steam workwhop will require it to be manually installed. You can do so by placing it into `.../Documents/Paradox Interactive/Hearts of Iron IV/mod/lotr`, then copy-pase the `descriptor.mod` file from within into the folder outside, rename it to `lotr.mod` and add the line `path=".../Documents/Paradox Interactive/Hearts of Iron IV/mod/lotr"` to the bottom of it. (Change the three dots to your corresponding user directory and do *not* use back-slashes).
+
+## Contributing
+
+If you want to contribute to this project, feel free to get in touch through discord or open a pull request!
+
+Not that by opening a pull-request you grant us a perpetual permission to use the contents therein for this mod (unless explicitly agreed otherwise). Please stick with CC/public domain resources, give credit where necessary, or make sure you have an appropriate license for external assets.
+
+Note: The `dev` branch and the derivatives thereof are our working branches. The `master` branch reflects what is live on the workshop and is only commited to when a new patch is released.
+
+We recommend looking through our [Wiki pages](https://github.com/HoI4-LOTRMod-Team/HoI4-LotrMod/wiki) for information on the codebase and familiatizing yourself with our custom GFX scripts.
+
+We also recommend using our custom [GFX Search Tool](https://hoi4-lotrmod-team.github.io/HoI4-LotrMod) to find appropriate images/icons for your focuses, events etc.
 
+### Disclaimer
 
-**Important Note:** Several parts of this mod are licensed *exclusively* to this project. Do not re-use or re-upload any assets from this repository in or to any other projects without express permission from the authors.
+Several parts of this mod are licensed *exclusively* to this project. Do not re-use or re-upload any assets from this repository in or to any other projects without express permission from the authors.

common/achievements/achievements.txt

@@ -0,0 +1,269 @@
+
+
+unique_id = lotr_achievements
+
+#General
+wizards_should_know_better = {
+	possible = {
+		achievement_standard_possible_check = yes
+        NOT = { tag = ISE }
+	}
+
+	happened = {
+        has_government = cooperative
+        OR = {
+            ISE = {
+                is_puppet_of = ROOT
+            }
+            controls_state = 31
+        }
+	}
+}
+
+one_ring_to_rule_them_all = {
+	possible = {
+		achievement_standard_possible_check = yes
+	}
+
+	happened = {
+		ROOT = {
+			ring_has_the_ring = yes
+		}
+	}
+}
+
+revenge_for_the_battle_of_the_five_armies = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = GUN
+	}
+
+	happened = {
+		ERE = {
+			all_core_state = {
+				is_controlled_by = ROOT
+			}
+		}
+		MIR = {
+			all_core_state = {
+				is_controlled_by = ROOT
+			}
+		}
+		DAL = {
+			all_core_state = {
+				is_controlled_by = ROOT
+			}
+		}
+		OR = {
+			DGU = { is_puppet_of = ROOT }
+			DGU = { all_core_state = { is_controlled_by = ROOT } }
+		}
+
+	}
+}
+
+#Angmar
+ANG_the_necromancer = {
+	possible = {
+		achievement_standard_possible_check = yes
+        tag = ANG
+	}
+
+	happened = {
+        tag = ANG
+		has_country_flag = ANG_sauron_returned
+        has_government = belligerent
+	}
+}
+
+#Shire
+SHI_taking_the_hobbits_to_isengard = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = SHI
+	}
+
+	happened = {
+		ISE = {
+			all_core_state = {
+				is_controlled_by = SHI
+			}
+		}
+	}
+}
+
+#Mordor
+MOR_not_my_dark_lord = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = MOR
+	}
+
+	happened = {
+		has_country_flag = MOR_orcs_have_taken_over_mordor
+		ANG = {
+			has_country_flag = ANG_sauron_returned
+		}
+		has_global_flag = orcs_of_mordor_declared_war_on_ANG_achievement_flag
+		has_global_flag = orcs_of_mordor_won_war_against_ANG_achievement_flag
+	}
+}
+
+#Dol Amroth
+DAM_god_damnroth = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = DAM
+	}
+
+	happened = {
+		set_temp_variable = { temp_gondor_factories = GON.num_of_factories }
+		multiply_temp_variable = { temp_gondor_factories = 2 }
+		custom_trigger_tooltip = {
+			tooltip = achievement_tooltip_get_twice_as_many_factories_as_gondor		
+			num_of_factories > temp_gondor_factories
+		}
+	}
+}
+
+#Entwood
+ENT_triple_tree_triumvirate = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = ENT
+	}
+
+	happened = {
+		LTH = {
+			all_core_state = {
+				is_controlled_by = ENT
+			}
+		}
+		MIR = {
+			all_core_state = {
+				is_controlled_by = ENT
+			}
+		}
+	}
+}
+
+#Moria
+MOR_morgoths_most_loyal_general = {
+	possible = {
+		achievement_standard_possible_check = yes
+		original_tag = MOA
+	}
+
+	happened = {
+		tag = MOC
+		has_completed_focus = submittothebalrog
+		is_in_faction_with = MOR
+		LTH = {
+			all_core_state = {
+				is_controlled_by = MOC
+			}
+		}
+		RIV = {
+			all_core_state = {
+				is_controlled_by = MOC
+			}
+		}
+	}
+}
+
+MOA_side_by_side_with_an_elf = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = MOA
+	}
+
+	happened = {
+		tag = MOA
+		MOA = {
+			MOA_gimli = {
+				is_unit_leader = yes
+			}
+		}
+		OR = {
+			is_in_faction_with = RIV
+			is_in_faction_with = LTH
+		}
+	}
+}
+
+#Isengard
+ISE_my_brother_my_captian_my_king = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = ISE
+	}
+
+	happened = {
+		has_global_flag = lurtz_killed_boromir_while_attacking_the_fellowship_the_achievement_flag
+	}
+}
+
+ISE_a_wizard_is_never_late = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = ISE
+	}
+
+	happened = {
+		has_government = cooperative
+		GON = {
+			OR = {
+				exists = no 
+				is_puppet_of = MOR
+				is_puppet_of = HAR
+				is_puppet_of = RHU
+			}
+		}
+		ROH = { 
+			OR = {
+				exists = no 
+				is_puppet_of = MOR
+				is_puppet_of = HAR
+				is_puppet_of = RHU
+			}
+		}
+		has_country_flag = ISE_won_war_against_MOR_flag
+	}
+}
+
+#Gondor
+GON_one_does_simply_walk_into_mordor = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = GON
+	}
+
+	happened = {
+		date < 3021.1.1
+		has_country_flag = GON_won_war_against_MOR_flag
+	}
+}
+
+GON_for_frodo = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = GON
+	}
+
+	happened = {
+		has_country_flag = GON_taken_black_gate_from_MOR_achievement_flag
+	}
+}
+
+#Lothlorien
+LTH_elven_boogaloo = {
+	possible = {
+		achievement_standard_possible_check = yes
+		tag = LTH
+	}
+
+	happened = {
+		has_global_flag = fs_ring_destroyed
+		has_global_flag = fs_elven_fellowship
+	}
+}

common/ai_strategy_plans/MOR_strategy_plans.txt

@@ -38,7 +38,7 @@ MOR_historical_plan = {
 		seekalliesintheeast
 		globalrailnetwork
 		railnetwork_to_the_east
-		warpreparations
+		MOR_war_preparations
 		honor_morgoth
 		unleashsauron
 		infrastructure_to_the_east