Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VOICEVOX#1879
の提案のために作ってみたけど欠点に気づいて引き換えした。
変更が多すぎるのは別に良い。
一方で元の目的の「UIがアニメーションしないようにする」を達成しづらかった。
アクセント句をmerge/splitする際、accentPhraseのidを一緒にするか変えるか、id的にはどっちでも良いはず。
でもUI的には元のidどちらとも違っていたほうが良い。
ということで、なんかおかしい。
UIにとってのkeyなので、理想的にはコンポーネント内でだけkeyを持っている方が良いかも。
ただそうなるとmergeやsplitもコンポーネント内で完結しないといけない。
それはCOMMANDの実装的にまずいかもしれない。
というメモ