Skip to content

Commit

Permalink
mention pull/1363 which fixes issues/1262, and bump requirement up to…
Browse files Browse the repository at this point in the history
… 2.1.2
  • Loading branch information
HinTak committed Nov 20, 2018
1 parent 28e67be commit 2e6fe54
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@ However, differences should not be beyond fractional pixels.
See below for output demos, and [vertical layout](README.vertical.md) for vertical-layout examples, [variation selector examples](variation-selectors.md).

All the images are generated by the [script](gen-images.sh), using either libre fonts or fonts from Windows.
They should be commonly accessible. Unfortunately you may need to edit the script slightly one way or the other to get
the margin calculation done consistently ( https://github.com/harfbuzz/harfbuzz/issues/1262 ,
https://github.com/harfbuzz/harfbuzz/issues/1248 ). `hb-view.py` itself does not use the margin values,
so these two problems are significant only if you want to pass the numbers to `c++ hb-view`.
They should be commonly accessible.

# Requirement

The descender/ascender code depends on a recent bug fix ( https://github.com/harfbuzz/harfbuzz/pull/1209 ) to harfbuzz from me.
This was merged after HarfBuzz version 1.9.0 and first appeared in 2.0.0 (released on Oct 18, 2018).
Another fix ( https://github.com/harfbuzz/harfbuzz/pull/1363 ) was merged and first appeared in 2.1.2 .

You need to build and install harfbuzz with introspection (`./configure --with-gobject --enable-introspection`), and have pygobject
(https://wiki.gnome.org/Projects/PyGObject). The latter should be readily available as pre-packaged on many systems.
Expand Down
2 changes: 1 addition & 1 deletion hb-view.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def tounicode(s, encoding='utf-8'):
else:
return s

if (hb.version_atleast(2,0,0)):
if (hb.version_atleast(2,1,2)):
pass
else:
raise RuntimeError('HarfBuzz too old')
Expand Down

0 comments on commit 2e6fe54

Please sign in to comment.