Automatic generation of constructors #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: fix constructor name comparison
TODO: Add new constructor to book and create file TODO: Test for all of the `book`
TODO: Test with current `book`
TODO: Test with full `book`
TODO: deal with cases like this: ``` assertion `left == right` failed left: "λn ~λP λsucc λzero (succ n)" right: "λpred ~λP λsucc λzero (succ pred)" ```
TODO: Change test to loop through the entire book
A few modules were selected to compare their constructors with the generated ones.
edusporto
force-pushed
the
auto-constructor
branch
from
e77cdeb to
258104a
Compare
edusporto
commented
Apr 11, 2024
| @@ -128,7 +128,7 @@ impl Show { | |||
| }, | |||
| Style::Glue => { | |||
| for (i, c) in child.iter().enumerate() { | |||
| if i > 0 { | |||
| if i > 0 && !c.is_empty() { | |||
There was a problem hiding this comment.
Need to check with Taelin that this won't break anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic generation of ADT constructors that could not be found by the book loading system.
Two points of discussion remain:
Suggestions are welcome!