Merge remote-tracking branch 'nabenabe0928/hotfix/fix-mypy-error-in-t…

…ests' into Apply-nabenabe-change
HideakiImamura · Feb 2, 2024 · 1aa083e · 1aa083e
2 parents e702018 + 2002c9a
commit 1aa083e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/windows-tests.yml b/.github/workflows/windows-tests.yml
@@ -118,6 +118,8 @@ jobs:
         pip install --progress-bar off .[optional]
         pip install --progress-bar off .[integration]
         pip install "distributed<2023.3.2"
+        # TODO(nabenabe0928): Remove the version constraint on Torch.
+        pip install "torch<2.2.0"
 
     - name: Output installed packages
       run: |

diff --git a/optuna/integration/pytorch_distributed.py b/optuna/integration/pytorch_distributed.py
@@ -21,7 +21,7 @@
 with try_import() as _imports:
     import torch
     import torch.distributed as dist
-    from torch.distributed import ProcessGroup  # type: ignore[attr-defined]
+    from torch.distributed import ProcessGroup
 
 
 if TYPE_CHECKING:

diff --git a/tests/artifacts_tests/test_boto3.py b/tests/artifacts_tests/test_boto3.py
@@ -11,10 +11,10 @@
 
 
 try:
-    from moto import mock_aws
+    # TODO(nabenabe0928): Replace it with `from moto import mock_aws` after dropping Python3.7.
+    from moto import mock_aws  # type: ignore[attr-defined]
 except ImportError:
-    from moto import mock_s3 as mock_aws
-
+    from moto import mock_s3 as mock_aws  # type: ignore[attr-defined,no-redef]
 
 if TYPE_CHECKING:
     from collections.abc import Iterator