[RIS-1259] Fix errors raised by gem builder #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trooney-himama
commented
Feb 6, 2024
Comment on lines
+9
to
+10
| spec.authors = ['HiMama'] | ||
| spec.email = ['[email protected]'] |
There was a problem hiding this comment.
Removing former employee from Ruby gems page:
(If someone feels like automating all the contributors, that's something we can look into.)
trooney-himama
commented
Feb 6, 2024
Comment on lines
+43
to
+44
| spec.add_dependency 'faraday-excon', '~> 2.1.0' | ||
| spec.add_dependency 'faraday-multipart', '~> 1.0.0' |
There was a problem hiding this comment.
gem build bambora-client.gemspec asks us to avoid unbounded requirements.
harrylewis
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On preparing
v0.7.0for release to Rubygems, I was prompted to fix the package requirements.Pinning versions to satisfy bundler, and updating some details in
gemspecso our authorship is referenced.Screenshots
Before
After
