Skip to content

Commit

Permalink
update CI to use classic spell list for older clients
Browse files Browse the repository at this point in the history
old clients can't properly load the main autospell db for RE, using the
herc-provided fallback makes them pass.
  • Loading branch information
guilherme-gm committed Oct 28, 2023
1 parent c8f99d5 commit 2ef226e
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/clang15_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ jobs:
HTTPLIB: ["", "--with-http_parser=llhttp"]
SANITIZER: ["--disable-manager", "--disable-manager --enable-sanitize=full"]
PACKET_VERSION: ["--enable-packetver=20221024", "--enable-packetver=20130724"]
include: # Use "CLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
include:
# Empty CLASSIC_AUTOSPELL_LIST for every other flow
- CLASSIC_AUTOSPELL_LIST: ""
# Use "-DCLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
- PACKET_VERSION: "--enable-packetver=20130724"
RENEWAL: ""
CLASSIC_AUTOSPELL_LIST: "-DCLASSIC_AUTOSPELL_LIST"
Expand Down Expand Up @@ -56,8 +59,7 @@ jobs:
INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client libmariadbclient-dev-compat
SQLHOST: mariadb
CC: ${{ matrix.CC }}
CPPFLAGS: ${{ (matrix.CLASSIC_AUTOSPELL_LIST != '' && matrix.CLASSIC_AUTOSPELL_LIST) || '' }}
CONFIGURE_FLAGS: CC=${{ matrix.CC }} --enable-debug --enable-Werror --enable-buildbot ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} CPPFLAGS="${{ env.CPPFLAGS }}"
CONFIGURE_FLAGS: ${{ format('CC={0} --enable-debug --enable-Werror --enable-buildbot {1} {2} {3} {4} {5} CPPFLAGS={6}', matrix.CC, matrix.RENEWAL, matrix.HTTPLIB, matrix.CLIENT_TYPE, matrix.SANITIZER, matrix.PACKET_VERSION, matrix.CLASSIC_AUTOSPELL_LIST) }}
PACKET_VERSION: ${{ matrix.PACKET_VERSION }}
steps:
- uses: actions/checkout@v1
Expand Down

0 comments on commit 2ef226e

Please sign in to comment.