Add typechecking for insert!

[nicolaefilat]

This pull request add typechecking when calling insert.
If trying to insert a subtree in a place where the wrong type is expected an error in thrown.

For this check the grammar is also needed as an extra argument. This, however, breaks HerbSearch for now.
I will create a PR for HerbSearch soon.

This should close #66.

[ReubenJ]

This breaks tests in HerbSearch, by the way. Maybe this is intended, but can you take a look to confirm?

To reproduce errors

using Pkg

Pkg.activate(; temp=true)

packages = [
    PackageSpec(name="HerbConstraints", rev="dev"),
    PackageSpec(name="HerbGrammar", rev="add-typechecking-for-insert!"),
    PackageSpec(name="HerbCore", rev="dev"),
    PackageSpec(name="HerbInterpret", rev="dev"),
    PackageSpec(name="HerbSearch", rev="dev"), 
    PackageSpec(name="HerbSpecification", rev="dev")
]
Pkg.add(packages)

Pkg.test("HerbSearch")  # test only the HerbSearch package instead of all packages

[nicolaefilat]

Yes it breaks because it adds an extra field to the cross_over function.
I have a fix ready for HerbSearch too but I did not make a PR for that.

[ReubenJ]

I have a fix ready for HerbSearch too but I did not make a PR for that.

Would you mind posting a PR for that?

[codecov]

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.93%. Comparing base (aca61f9) to head (3e1a45d).

Files with missing lines	Patch %	Lines
src/nodelocation.jl	73.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
+ Coverage   46.10%   48.93%   +2.83%     
==========================================
  Files           8        8              
  Lines         462      470       +8     
==========================================
+ Hits          213      230      +17     
+ Misses        249      240       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ReubenJ]

@nicolaefilat I'm sorry, but I've lost track of whether that PR for HerbSearch has already been posted and/or merged. Can you confirm, and if not, post one when you can?

Edit: looks like it's still causing some tests on HerbSearch to fail.