-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Aqua type piracy errors #31
Merged
Merged
+59
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 72.52% 73.54% +1.01%
==========================================
Files 1 2 +1
Lines 182 189 +7
==========================================
+ Hits 132 139 +7
Misses 50 50 ☔ View full report in Codecov by Sentry. |
ReubenJ
changed the title
Add pirated methods from
Address Aqua type piracy errors
Nov 25, 2024
HerbGrammar
ReubenJ
requested review from
THinnerichs and
pwochner
and removed request for
THinnerichs
November 25, 2024 11:53
They are better-suited as functions in `HerbGrammar`
ReubenJ
force-pushed
the
feat/anti-piracy
branch
from
November 26, 2024 16:55
9c63232
to
e3a5874
Compare
pwochner
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complaints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following methods from
HerbGrammar
were picked up byAqua
as pirated. They should be defined here because their input arguments are all types defined here inHerbCore
.The interface to AbstractTrees.jl
HerbCore.jl/src/rulenode.jl
Lines 19 to 21 in 1bf674c
These RuleNode/Hole Constructors
HerbCore.jl/src/rulenode.jl
Line 43 in 1bf674c
HerbCore.jl/src/rulenode.jl
Line 48 in 1bf674c
HerbCore.jl/src/rulenode.jl
Line 81 in 1bf674c
Base.show and Base.getindex definitions for AbstractGrammars
HerbCore.jl/src/grammar.jl
Lines 23 to 29 in 1bf674c
Addresses Herb-AI/HerbGrammar.jl#96 and Herb-AI/HerbGrammar.jl#97.