Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for rulesoftype #28

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Oct 18, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.78%. Comparing base (7997966) to head (6924368).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   54.59%   59.78%   +5.18%     
==========================================
  Files           2        1       -1     
  Lines         185      184       -1     
==========================================
+ Hits          101      110       +9     
+ Misses         84       74      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@THinnerichs THinnerichs self-requested a review October 21, 2024 12:49
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of small suggestions.

test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@ReubenJ ReubenJ self-requested a review October 29, 2024 09:51
Copy link
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@ReubenJ ReubenJ merged commit 22d1491 into Herb-AI:master Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants