Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter, doctests #63

Closed
wants to merge 4 commits into from
Closed

Add linter, doctests #63

wants to merge 4 commits into from

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Sep 6, 2024

All changes in src and test are a result of running the formatting script.

@ReubenJ ReubenJ self-assigned this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 64 lines in your changes missing coverage. Please review.

Project coverage is 75.17%. Comparing base (9f199f4) to head (a9aa1a6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/solver/uniform_solver/state_hole.jl 55.55% 12 Missing ⚠️
src/csg_annotated/csg_annotated.jl 0.00% 6 Missing ⚠️
src/solver/generic_solver/treemanipulations.jl 62.50% 6 Missing ⚠️
src/localconstraints/local_contains.jl 0.00% 5 Missing ⚠️
src/localconstraints/local_ordered.jl 0.00% 5 Missing ⚠️
src/grammarconstraints/forbidden.jl 55.55% 4 Missing ⚠️
src/grammarconstraints/ordered.jl 33.33% 4 Missing ⚠️
src/localconstraints/local_contains_subtree.jl 70.00% 3 Missing ⚠️
src/localconstraints/local_forbidden.jl 0.00% 3 Missing ⚠️
src/solver/uniform_solver/uniform_solver.jl 70.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   75.47%   75.17%   -0.30%     
==========================================
  Files          31       31              
  Lines        1382     1402      +20     
==========================================
+ Hits         1043     1054      +11     
- Misses        339      348       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReubenJ ReubenJ marked this pull request as ready for review September 6, 2024 09:59
@ReubenJ ReubenJ added the ci Relating to continuous integration, actions, etc. label Sep 6, 2024
@ReubenJ ReubenJ marked this pull request as draft September 27, 2024 08:41
@ReubenJ
Copy link
Member Author

ReubenJ commented Dec 12, 2024

Closing in favor of BestieTemplate

@ReubenJ ReubenJ closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Relating to continuous integration, actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant