Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool enhancement - Tox Tools DR modelling #67

Merged
merged 44 commits into from
Nov 4, 2024
Merged

Tool enhancement - Tox Tools DR modelling #67

merged 44 commits into from
Nov 4, 2024

Conversation

rmassei
Copy link
Contributor

@rmassei rmassei commented Oct 30, 2024 •
edited
Loading

Small enhancement of the DR tool:

  1. Add compound name to the DR graph and the csv output. This improves the data sorting if the tool is included in a workflow with many chemicals.

rmassei and others added 30 commits October 11, 2024 09:47
@rmassei
add new tools (omero get and omero filter) and updated the ci/pr pipe…
55b8878 
…line to add metadat to the dummy set)
@lldelisle
use conditionals to more explicitely indicate the id required.
1ee41a8
@lldelisle
fix annotation part
85c9889
@lldelisle
convert omero_get to omero_get_id
a18ab9d
@lldelisle
add get_value
6045586
@lldelisle
add single quotes
4351fdf
@lldelisle
Fix bad copy paste
f81b04d
@lldelisle
add tests
f9e9b42
@lldelisle
remove unused f
a62a925
@lldelisle
remove unused function
9293ed3
@lldelisle
fix function name
3385216
@lldelisle
fix spaces
ecf3085
@rmassei
Merge pull request #3 from lldelisle/improve_omero_get
21e04d4 
Improve omero get
@rmassei
Updated all the scripts and xml files according to previous review
a0511de
@rmassei
correct indentation of omero_filter and omero_get_id
a9b6b41
@rmassei
Update omero_filter.py
fdafaeb 
Fixed the error handling using sys
@rmassei
fixed code and xml from omero_filter for correct linting
48b09d5
@rmassei
Merge branch 'omero-upload' of github.com:rmassei/mb-galaxy-tools int…
bb43db1 
…o omero-upload
@rmassei
correct image name
cefb3b0
@rmassei
fixed indentation
483f29f
@rmassei
fix the regex of omero_get_value and updated the sheed
f1665dc
@rmassei
fixed the regex to handle single number plus comma separated numbers
b34059b
@rmassei
Fix testing in output and omero_get_value.xml
904261b
@rmassei
Correct the cheetah sintax in omero_get_value.xml
0417225
@rmassei
Correct the test in omero_get_value.xml - tsv output has 2 rows consi…
54487c9 
…dering the header
@rmassei
Last corrections to the omero_get_value script to harmonize it with t…
a720d50 
…he other code style (writing tsv in write mode and error handling)
@bernt-matthias
add macros
707dbdf
@bernt-matthias
omero import do not expose password
f81311b
@bernt-matthias
add requirement macros
823505a
@bernt-matthias
add host port token
222d6f7
rmassei
rmassei commented Oct 30, 2024
View reviewed changes
Copy link
Contributor Author

@rmassei rmassei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go!

@bernt-matthias bernt-matthias merged commit 8b68231 into Helmholtz-UFZ:main Nov 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernt-matthias bernt-matthias bernt-matthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmassei @bernt-matthias @lldelisle