Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update highlighter library #472

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Update highlighter library #472

merged 4 commits into from
Aug 2, 2024

Conversation

tobil4sk
Copy link
Member

Update the highlighter library so we can finally stop depending on an ancient version of nodejs.

See: ibilon/Highlighter#5

@tobil4sk
Copy link
Member Author

Hm, just tested it and highlighting is a bit broken now 😅...
image

@tobil4sk
Copy link
Member Author

A bit better now, but something odd is happening with if while and possibly other keywords:
Before:
image

Now:
image

@tobil4sk
Copy link
Member Author

Ok, I got it now, it looks like I had messed up the order of theme settings when themes have parent themes.
image

@kLabz
Copy link
Contributor

kLabz commented Jul 27, 2024

Would need to merge ibilon/Highlighter#5 first and update install path here :)

Other than that, it seems ok (I didn't test the website locally yet, though)
What's the added vscode-oniguruma dependency for?

@tobil4sk
Copy link
Member Author

What's the added vscode-oniguruma dependency for?

I think it has replaced oniguruma but it now has to be installed separately and vscode-textmate has to be pointed to use it:
https://github.com/microsoft/vscode-textmate?tab=readme-ov-file#using. I tried to get by without using it but it broke something.

@tobil4sk
[earthly] Update earthly image
f1c02b9 
focal has a node version that is too old
@tobil4sk
Update readme setup info
57d7b40 
We no longer need an ancient version of node for vscode-textmate
@tobil4sk
Show generator complete message only when complete
35a90db
@tobil4sk
Copy link
Member Author

Would need to merge ibilon/Highlighter#5 first and update install path here :)

Done!

@kLabz kLabz merged commit 59b2587 into HaxeFoundation:staging Aug 2, 2024
2 checks passed
@tobil4sk tobil4sk deleted the update-highlighter branch August 2, 2024 07:01
kLabz pushed a commit that referenced this pull request Aug 7, 2024
@tobil4sk @kLabz
Update highlighter library (#472)
58cb5d2 
* Update highlighter library

* [earthly] Update earthly image

focal has a node version that is too old

* Update readme setup info

We no longer need an ancient version of node for vscode-textmate

* Show generator complete message only when complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobil4sk @kLabz