add ArcFace verifier #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frechele
requested changes
Nov 26, 2022
| print('cpu 사용, 시간이 오래걸리기 때문에 gpu를 이용하는 것을 권장합니다.') | ||
| df_detection = detect_images_by_cpu(yolo_detector, video_name) | ||
| else: | ||
| print('아직 미구현') |
There was a problem hiding this comment.
raise NotImplementedError(f"구현되지 않은 detector {detector}")같은 형태로 수정하는 것이 좋겠습니다.
| # filter 된 dataframe | ||
| df_filtered = filter_df(df_detection) | ||
| # 데이터프레임 저장 | ||
| df_filtered.to_parquet(f'./dataset/{video_name}/detection_data/yoloface_data.parquet',engine='pyarrow') |
There was a problem hiding this comment.
./dataset/{video_name}/detection_data/yoloface_data.parquet 위치는 위에도 쓰이는 걸로 보아 특별한 파일 위치로 보이는데요, 별도의 상수로 빼는 게 좋을 것 같습니다.
Comment on lines
+79
to
+80
| imgs_path = [f'./dataset/{self.video_name}/frame/{frame}/{videonum1}.jpg', | ||
| f'./dataset/{self.video_name}/frame/{frame}/{videonum2}.jpg'] |
There was a problem hiding this comment.
self.root = f"./dataset/{self.video_name}" 같은 걸로 캐싱해두고, os.path.join으로 다른데선 root directory 신경 안쓰도록 하는 게 좋을 것 같네요. (위에 comment도 비슷하게 처리해주세요)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.