Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flag to disable SSBO alignment workaround #1983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emryd
Copy link

@emryd emryd commented May 4, 2024

Add no_ssbo_alignment config flag to disable SSBO alignment workaround.

This fixes the crashes in Horizon: Forbidden West in the Death's Door area which appear for some users, tested on a GeForce GTX 1080. See ValveSoftware/Proton#7590 (comment) for similar crashes reports.

Here is a debug log when such crashes occur:

6769.539:011c:01fc:info:vkd3d-proton:vkd3d_pipeline_library_disk_thread_main: Flushing disk cache (wakeup counter since last flush = 319). It seems like application has stopped creating new PSOs for the time being.

@HansKristian-Work
Copy link
Owner

HansKristian-Work commented May 6, 2024

I don't buy outright that this is a fix. This will also completely cripple performance, since no descriptor buffer and offset buffers for SSBO which is devastatingly bad.

We also use NV_raw_access_chains on NV, which makes alignment fully driven by shader anyway.

Copy link
Owner

@HansKristian-Work HansKristian-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need actual proof of what is going on. To start with, a reproducing save file would be needed to progress this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants