Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ユーザーの名前を制限できるように #88

Merged
merged 14 commits into from
Oct 13, 2024

Conversation

kanarikanaru
Copy link
Member

What

  • ユーザーのスクリーンネームをを正規表現を使って制限できるようにする

Why

  • モデレーション

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

github-actions bot commented Oct 11, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -199,6 +199,12 @@
                         "type": "string"
                       }
                     },
+                    "prohibitedPartialScreenNames": {
+                      "type": "array",
+                      "items": {
+                        "type": "string"
+                      }
+                    },
                     "bannedEmailDomains": {
                       "type": "array",
                       "items": {
@@ -604,6 +610,7 @@
                     "blockedHosts",
                     "sensitiveWords",
                     "prohibitedWords",
+                    "prohibitedPartialScreenNames",
                     "preservedUsernames",
                     "hcaptchaSecretKey",
                     "mcaptchaSecretKey",
@@ -13805,6 +13812,15 @@
                       "type": "string"
                     }
                   },
+                  "prohibitedPartialScreenNames": {
+                    "type": [
+                      "array",
+                      "null"
+                    ],
+                    "items": {
+                      "type": "string"
+                    }
+                  },
                   "themeColor": {
                     "type": [
                       "string",
@@ -51828,6 +51844,16 @@
                       }
                     }
                   },
+                  "SCREEN_NAME_CONTAINS_PROHIBITED_WORDS": {
+                    "value": {
+                      "error": {
+                        "message": "Screen name contains prohibited words.",
+                        "code": "SCREEN_NAME_CONTAINS_PROHIBITED_WORDS",
+                        "id": "0b3f9f6a-2f4d-4b1f-9fb4-49d3a2fd7191",
+                        "httpStatusCode": 422
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

@kakkokari-gtyih
Copy link

kakkokari-gtyih commented Oct 11, 2024

チュートリアルのユーザー名設定の方にも同様のエラーダイアログを入れる必要がありそう

@kanarikanaru
Copy link
Member Author

Screenshot 2024-10-11 at 19 49 23 今の状態でも出るかも

@kakkokari-gtyih
Copy link

あー
osのほういじったのか

@kanarikanaru
Copy link
Member Author

こっちには共通エラーってことなら多分変えたほうがいいわね

Copy link

@kakkokari-gtyih kakkokari-gtyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たぶんok

@kanarikanaru
Copy link
Member Author

マージする

@kanarikanaru kanarikanaru merged commit 0db1df7 into hanami Oct 13, 2024
28 checks passed
@kanarikanaru
Copy link
Member Author

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the feat-limit-user-screen-name branch October 13, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants